Move users list to administrator module #4969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
added
the
refactor
AntonKhorev
force-pushed
the
administrator-scope-users
branch
3 times, most recently
from
d1a184d to
31f88e4
Compare
AntonKhorev
force-pushed
the
administrator-scope-users
branch
from
31f88e4 to
72c87d4
Compare
|
After back-and-forth in #4587 a different module scheme was chosen, so this probably needs updating. |
|
Superseded by #5391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to rename
user_new_path, it's standard name should benew_user_path. I tried using resourceful routes but we havecreateaction mapped toPOST/user/newwhich is also nonstandard. Then I'd have to do bothnewandcreateactions with resourceful routes and this will want to rewriteusers_path.users_pathis currently mapped to admin users list. I have to rename it first which is easier to do if I move it to a different module.